Repository navigation
PR-A0: manual witness API repin (post-#6520 structural termination) - #6529
Merged
briansrls merged 2 commits intoJul 13, 2026
Merged
Conversation
… API #6520 removed descent fuel/remaining from body_lowering_fold helpers; the manual add/match/projection witnesses still called the old Outcome+remaining signatures and failed to resolve. Re-pin to Optional/Outcome shapes and update the match-arm RED control note for structural termination. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
changed the title
Contributor
|
Verified the composer-2.5 approval against current HEAD (
No fix commit warranted — mechanical alignment only, scope matches PR-A intent. — sent from silent-lynx-25 |
Contributor
|
Verified the claude-opus-4-7 approval against HEAD (
No fix commit warranted — tests-only mechanical alignment, already covered by prior verification comment. — sent from silent-lynx-25 |
gunbai-bot
Bot
changed the title
briansrls
deleted the
session/silent-lynx-25-pr-a-body-lowering-witness-api
branch
July 13, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-A for Wave 1 criterion 1 (general body producer), building on merged anchor #6526 and implementation #6520.
#6520 removed descent fuel (
remaining/body_lowering_descent) frombody_lowering_fold— termination is now structural via the normalize child-fold. The manual body-lowering witnesses (body_lowering_normalize_add,body_lowering_match,body_lowering_projection_call) still called the pre-#6520Outcome+remainingsignatures and failed to resolve.This PR re-pins those witnesses to the current API (
Optionalfor unwrap/domain/infix helpers;Outcomewithoutremainingfor arrow/match/postfix paths) and updates the match-arm navigation RED control note for structural termination.Not in scope (later PR-B→E): FLAG E row-fold, resolve param-scaffold dissolution, Stage B/C/D.
Test plan
claim_batch --entry src/v2/test/claim/manual/body_lowering_normalize_add.dag --function body_lowering_normalize_yields_arrow— PASSclaim_batch --entry src/v2/test/claim/manual/body_lowering_match.dag --function body_lowering_match_lowers_to_match --function body_lowering_match_unnavigable_arm_refuses --function body_lowering_normalized_module_has_match— PASSclaim_batch --entry src/v2/test/claim/manual/body_lowering_projection_call.dag --function body_lowering_projection_lowers_to_transform— PASSclaim_batch --entry src/v2/test/claim/body_lowering_wrapper_retained_test.dag --function body_lowering_wrapper_retained_diagnostics_holds— PASSclaim_batch --entry src/v2/test/claim/body_lowering_well_formed_wall_test.dag— both fns PASSclaim_batch --entry src/v2/test/claim/self_host/wave1_gate1_general_body_producer_witness_test.dag --function wave1_gate1_body_producer_modules_import_resolve_holds— PASS (no regression on test(self-host): Wave 1 gate 1 general body producer verification witnesses #6526 anchor)